On Friday, February 17, 2017, Maxime Chassagneux < [email protected]> wrote:
> Hi Philippe, > > Thanks for all your remarks, I have to be more careful. > Again sorry for this, I'm not used to SVN. My notes were not a reproach :) Just to inform you about practices on project thay you cannot guess except for javadocs :) > > Regards > > 2017-02-17 13:56 GMT+01:00 Philippe Mouawad <[email protected] > <javascript:;>>: > > > Hello Maxime, > > I've fixed the problem. > > > > Regarding your first commits on project, few notes: > > > > - For any bug or enhancement, for now we should always create a > > bugzilla. PR only should in my opinion only be used for Technical > > improvements of code (Sonar fixes) or translations for example => > DONE > > - Once you have commited, ensure you put as comment the commit message > > in the bugzilla. This allows better understanding of fixes and better > > tracability > > - Code should have javadocs for all public methods and for classes, > and > > avoid introducing new javadoc errors. => TODO on last commit > > - When you add a new Java class, ensure you set SVN property: svn:eol > = > > native and add a new line at end of file. For XML it's usually LF => > > DONE > > > > Thanks > > > > Regards > > > > On Fri, Feb 17, 2017 at 9:41 AM, Maxime Chassagneux < > > [email protected] <javascript:;>> wrote: > > > > > Hi, > > > > > > Actualy the build fail because of my new JUnit for JMS. > > > I have a problem to preserve encoding file. > > > Someone can help me ? > > > > > > > > > > > -- > > Cordialement. > > Philippe Mouawad. > > > -- Cordialement. Philippe Mouawad.
