On 28 February 2017 at 22:40, Philippe Mouawad <philippe.moua...@gmail.com> wrote: > On Tue, Feb 28, 2017 at 11:25 PM, sebb <seb...@gmail.com> wrote: > >> On 28 February 2017 at 22:06, Philippe Mouawad >> <philippe.moua...@gmail.com> wrote: >> > On Tue, Feb 28, 2017 at 11:01 PM, sebb <seb...@gmail.com> wrote: >> > >> >> On 28 February 2017 at 21:54, Philippe Mouawad >> >> <philippe.moua...@gmail.com> wrote: >> >> > Hello, >> >> > We're now at: >> >> > >> >> > - 48 Enhancements >> >> > - 31 bug fixes >> >> > >> >> > Sebb has fixed Windows failures on Jenkins >> >> > >> >> > - Ensure the migrated docs (from PDF) do not contain old "Urban >> >> legends" >> >> > :-) nor bad practices. Those are the 4 Tutorial links in left >> menu. It >> >> > would be nice to review them. I've fixed some but not done the full >> >> work >> >> > >> >> > TODO >> >> > >> >> > - Fill in introduced properties in properties_reference.xml >> >> >> >> Remove obsolete references (e.g. some logging ones ?) >> >> >> > >> > Which ones ? >> > I made the cleanup. >> > Did I forget something ? >> > >> >> >> >> Add logging documentation. >> >> >> > It has been done in properties_reference.xml >> >> There is only some mention of HttpClient logging there. >> >> I could not find any description as to how to set the level for a >> specific JMeter class. >> > > I think this is pretty easy to find on internet knowing we use log4j2 and > slf4j. > But if you think we should add some doc, feel free to do it.
Sorry, but that is not good enough. I did not want the hassle of changing the logging. You did want the change. The change was agreed to on the basis that updated documentation was essential. There do not need to be reams of docs, but there should be at least couple of sentences as to how to configure the logging that will be readily understandable to someone used to the old ways. And plugin writers need to be told how to update their plugins. >> >> jmeter.properties used to describe this in some detail. >> The updated description probably does not belong there, but there >> should at least be a pointer to where to find the new information. >> >> >> >> >> Remove remaining references to older logging API. >> >> >> > >> > Where ? >> > I thought I had done it >> >> The string log_level appears in quite a few places. >> AFAIK it is not used in the new scheme >> > I have removed them. > Let me know if I still missed something I don't know if there is anything else. I just happened to notice that reference. > Thanks > >> >> >> >> >> > >> >> > DONE >> >> > >> >> > - If possible add JUnits on the regression introduced in GET with >> no >> >> > body (see my mail) >> >> > >> >> > DONE >> >> > >> >> > - Fill in New and Noteworthy section >> >> > >> >> > TODO >> >> > >> >> > >> >> > Are you ok to start a release soon ? >> >> > >> >> > Thanks >> >> > >> >> > Regards >> >> > >> >> > On Tue, Feb 21, 2017 at 4:21 PM, sebb <seb...@gmail.com> wrote: >> >> > >> >> >> I'm seeing some test failures on Windows. >> >> >> >> >> >> I've started to set up a Jenkins build to be able to catch these. >> >> >> (at present the failure mails are sent direct to me) >> >> >> >> >> >> Depending on the cause, the failures need to be fixed before the next >> >> >> release. >> >> >> >> >> >> On 11 February 2017 at 10:22, Philippe Mouawad >> >> >> <philippe.moua...@gmail.com> wrote: >> >> >> > Hello, >> >> >> > Since our discussion on "Release a 3.2 ?" , trunk has nicely >> evolved: >> >> >> > >> >> >> > - 33 Enhancements >> >> >> > - 25 bug fixes >> >> >> > >> >> >> > I think we can now plan a release. >> >> >> > >> >> >> > I see the following remaining work: >> >> >> > >> >> >> > - Ensure the migrated docs (from PDF) do not contain old "Urban >> >> >> legends" >> >> >> > :-) nor bad practices. Those are the 4 Tutorial links in left >> >> menu. It >> >> >> > would be nice to review them. I've fixed some but not done the >> full >> >> >> work >> >> >> > - Fill in introduced properties in properties_reference.xml >> >> >> > - If possible add JUnits on the regression introduced in GET >> with >> >> no >> >> >> > body (see my mail) >> >> >> > - Fill in New and Noteworthy section >> >> >> > >> >> >> > >> >> >> > >> >> >> > -- >> >> >> > Cordialement. >> >> >> > Philippe Mouawad. >> >> >> >> >> > >> >> > >> >> > >> >> > -- >> >> > Cordialement. >> >> > Philippe Mouawad. >> >> >> > >> > >> > >> > -- >> > Cordialement. >> > Philippe Mouawad. >> > > > > -- > Cordialement. > Philippe Mouawad.
