On 6 April 2017 at 16:06, <[email protected]> wrote: > Author: pmouawad > Date: Thu Apr 6 15:06:32 2017 > New Revision: 1790418 > > URL: http://svn.apache.org/viewvc?rev=1790418&view=rev > Log: > Take into account sebb note
Thanks for fixing the comment. But please in future use a log message that is specific to the change. Log messages serve at least two purposes: - info for devs reviewing the commit mail - info for maintainers looking through the file history So for example 'Bug 12345 - fix xyz' is fine. 'Bug 12345' on its own is not as good, because it requires the reader to look up the bug Some simpler changes don't need much info, e.g. 'Typo' 'Unused import' 'Indentation' > Modified: > > jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HeaderManager.java > > Modified: > jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HeaderManager.java > URL: > http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HeaderManager.java?rev=1790418&r1=1790417&r2=1790418&view=diff > ============================================================================== > --- > jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HeaderManager.java > (original) > +++ > jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/control/HeaderManager.java > Thu Apr 6 15:06:32 2017 > @@ -232,7 +232,7 @@ public class HeaderManager extends Confi > * if <code>element</code> is not an instance of > * {@link HeaderManager} > * > - * @deprecated use {@link HeaderManager#merge(TestElement)} as this > method will be removed in a future version > + * @deprecated since 3.2, use {@link HeaderManager#merge(TestElement)} > as this method will be removed in a future version > */ > @Deprecated > public HeaderManager merge(TestElement element, boolean > preferLocalValues) { > >
