On 28 March 2017 at 19:59, <[email protected]> wrote:
> Author: pmouawad
> Date: Tue Mar 28 18:59:34 2017
> New Revision: 1789193
>
> URL: http://svn.apache.org/viewvc?rev=1789193&view=rev
> Log:
> Bug 60112 - Report / Dashboard : Add ability to customize APDEX thresholds
> per Transaction name
> Contributed by Stephane Leplus
> This closes #287
> Bugzilla Id: 60112
>
==============================================================================
> ---
> jmeter/trunk/test/src/org/apache/jmeter/report/dashboard/ApdexPerTransactionTest.java
> (added)
> +++
> jmeter/trunk/test/src/org/apache/jmeter/report/dashboard/ApdexPerTransactionTest.java
> Tue Mar 28 18:59:34 2017
> @@ -0,0 +1,144 @@
> + private static String getOptionalProperty(Props props,
> + String key, Class clazz) {
> + String property = getProperty(props, key, null, clazz);
> + if (property != null) {
> + }
What is the point of the previous statement?
> + return property;
> + }
> +
> + private static String getProperty(Props props, String key,
> + String defaultValue, Class clazz)
The clazz parameter is not used.
Why not?
If the parameter is not needed here, then it's also not needed by the
previous method.
> + {
> + String value = props.getValue(key);
> + if (value == null) {
> + return defaultValue;
> + }
> + return value;
> + }
> +}
>
Note: this class is the one that fails on Windows.
