On Monday, April 10, 2017, <[email protected]> wrote:
> Author: mchassagneux
> Date: Mon Apr 10 14:43:56 2017
> New Revision: 1790839
>
> URL: http://svn.apache.org/viewvc?rev=1790839&view=rev
> Log:
> Don't cumul intial delay + ramp-up delay for a new thread create in the
> fly.
> Bugzilla Id: 60530
>
> Modified:
> jmeter/trunk/src/core/org/apache/jmeter/threads/ThreadGroup.java
>
> Modified: jmeter/trunk/src/core/org/apache/jmeter/threads/ThreadGroup.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/
> apache/jmeter/threads/ThreadGroup.java?rev=1790839&
> r1=1790838&r2=1790839&view=diff
> ============================================================
> ==================
> --- jmeter/trunk/src/core/org/apache/jmeter/threads/ThreadGroup.java
> (original)
> +++ jmeter/trunk/src/core/org/apache/jmeter/threads/ThreadGroup.java Mon
> Apr 10 14:43:56 2017
> @@ -385,6 +385,8 @@ public class ThreadGroup extends Abstrac
> numThreads = getNumThreads();
> setNumThreads(numThreads + 1);
> }
> + // Don't cumul intialDelay + rampup delay
> + setDelay(0);
-1
The fix does not look good to me.
Why touch the delay of thread group here ?
such change requires non regression test.
We're also in the middle of RC, commits are usually avoided except for
tests.
> newJmThread = startNewThread(notifier, threadGroupTree, engine,
> numThreads, context, now, delay);
> JMeterContextService.addTotalThreads( 1 );
> log.info("Started new thread in group {}", groupNumber);
>
>
>
--
Cordialement.
Philippe Mouawad.
