GitHub user FSchumacher opened a pull request:
https://github.com/apache/jmeter/pull/298
Vary header cache
First try on an implementation to support vary header as asked for in
https://bz.apache.org/bugzilla/show_bug.cgi?id=61176
Do not merge.
I haven't written tests yet, as I am not sure, if the code is going in the
right direction.
The idea at the moment is to store two entries in the cache, when a vary
header is found in the response headers. One entry for the original url with
the name of the vary header set and one entry for the
url+var-header-name+vary-header-value (of the request).
The code makes it clearer, that the two http samplers with slightly
different implementation details make it harder to implement this. For example
both samplers have different notions of how the headers are implemented.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/FSchumacher/jmeter vary-header-cache
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/jmeter/pull/298.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #298
----
commit d9c5a69e9d13ecff22897214b5fed19114980f41
Author: Felix Schumacher <[email protected]>
Date: 2017-06-18T14:41:31Z
Let the logging facade decide, whether we are in the correct logging mode.
We are not not doing any real work here and it simplifies our code.
commit b0d306cf6eaaf47b7400e47c23184e5999140fed
Author: Felix Schumacher <[email protected]>
Date: 2017-06-18T14:47:06Z
Use log string templates instead of string concatenation.
This should make the code a bit more readable.
commit fe4c0fb10b5dd1d046ffc32ec52c2eac5c782811
Author: Felix Schumacher <[email protected]>
Date: 2017-06-18T15:15:45Z
Extract code into local private methods.
Extract the various methods for calculation of the expiration date into
smaller methods in an attempt to make code more readable.
commit 6bb6e8e8929a9296fc2bfbe4d6da684efce3f1a6
Author: Felix Schumacher <[email protected]>
Date: 2017-06-18T15:16:39Z
Rename local variable to comply with java naming conventions.
commit fb661dfc575077421405167c94ed8c891fe608d7
Author: Felix Schumacher <[email protected]>
Date: 2017-06-18T15:24:47Z
Reformat to make it easier to read.
commit f38a460b3040421a14978b44292cf6eac5a41e91
Author: Felix Schumacher <[email protected]>
Date: 2017-06-19T18:23:03Z
Use vary header information for caching.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
