Hello Emilian, Thanks for your work which looks very promising. I've started tests and reported some issues at: - https://github.com/apache/jmeter/pull/300
Regards On Sat, Jul 22, 2017 at 6:04 PM, Emilian Bold <emilian.b...@gmail.com> wrote: > Hello, > > See my undo/redo commits > https://github.com/emilianbold/jmeter/commits/emilianbold-undoredo > > The 1st commit [1] fixes #57039 -- it was a matter of sharing internal > data and then editing that in the UI. > > The other commit [2] rewrites part of UndoHistory using the standard > javax.swing.undo classes and also introduces the concept of an 'undo > transaction'. > > This is needed to group multiple changes like the node changes after > "Search for a node by name". > > The are probably many other places that need some > beginUndoTransaction/endUndoTransaction pairs, I've only added a few. > > Also, we probably need a way to temporarily disable UndoHistory, for > example during loading. I haven't tested this, so please confirm if > loading large files has a big impact with undo enabled. > > Some low hanging fruit exists for compound edits where we could > merge/swallow edits. > > 1. https://github.com/emilianbold/jmeter/commit/ > ea9859995d1fb53905b720bc57a1ddf283b29ce8 > 2. https://github.com/emilianbold/jmeter/commit/ > 401221e9f6e480e43fcf51ee99458a0d7fdd661d > > --emi > -- Cordialement. Philippe Mouawad.
