Github user emilianbold commented on a diff in the pull request:

    https://github.com/apache/jmeter/pull/300#discussion_r131211056
  
    --- Diff: src/core/org/apache/jmeter/gui/SimpleCompoundEdit.java ---
    @@ -0,0 +1,14 @@
    +package org.apache.jmeter.gui;
    +
    +import javax.swing.undo.CompoundEdit;
    +
    +public class SimpleCompoundEdit extends CompoundEdit {
    +
    +    public boolean isEmpty() {
    +        return size() == 0;
    --- End diff --
    
    To `edits`? Seems a matter of taste. I would prefer to limit access to the 
protected variable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to