Hi Antonio, Why enable restart as it is taken into account immediately no ? It can confuse users who might think a restart is required.
Thanks On Tuesday, September 5, 2017, <[email protected]> wrote: > Author: agomes > Date: Tue Sep 5 17:26:11 2017 > New Revision: 1807374 > > URL: http://svn.apache.org/viewvc?rev=1807374&view=rev > Log: > Enable restart when prefix is modified in proxy recorder > > Modified: > jmeter/trunk/src/protocol/http/org/apache/jmeter/ > protocol/http/proxy/gui/ProxyControlGui.java > jmeter/trunk/xdocs/changes.xml > > Modified: jmeter/trunk/src/protocol/http/org/apache/jmeter/ > protocol/http/proxy/gui/ProxyControlGui.java > URL: http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/ > http/org/apache/jmeter/protocol/http/proxy/gui/ProxyControlGui.java?rev= > 1807374&r1=1807373&r2=1807374&view=diff > ============================================================ > ================== > --- jmeter/trunk/src/protocol/http/org/apache/jmeter/ > protocol/http/proxy/gui/ProxyControlGui.java (original) > +++ jmeter/trunk/src/protocol/http/org/apache/jmeter/ > protocol/http/proxy/gui/ProxyControlGui.java Tue Sep 5 17:26:11 2017 > @@ -631,6 +631,7 @@ public class ProxyControlGui extends Log > enableRestart(); > } else if(fieldName.equals(PREFIX_HTTP_SAMPLER_NAME)) { > model.setPrefixHTTPSampleName(prefixHTTPSampleName.getText() > ); > + enableRestart(); > } > } > > @@ -817,7 +818,6 @@ public class ProxyControlGui extends Log > prefixHTTPSampleName = new JTextField(4); > prefixHTTPSampleName.addKeyListener(this); > prefixHTTPSampleName.setName(PREFIX_HTTP_SAMPLER_NAME); > - // TODO Not sure this is needed > prefixHTTPSampleName.setActionCommand(ENABLE_RESTART); > JLabel labelPrefix = new JLabel(JMeterUtils. > getResString("proxy_prefix_http_sampler_name")); // $NON-NLS-1$ > labelPrefix.setLabelFor(prefixHTTPSampleName); > > Modified: jmeter/trunk/xdocs/changes.xml > URL: http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes. > xml?rev=1807374&r1=1807373&r2=1807374&view=diff > ============================================================ > ================== > --- jmeter/trunk/xdocs/changes.xml [utf-8] (original) > +++ jmeter/trunk/xdocs/changes.xml [utf-8] Tue Sep 5 17:26:11 2017 > @@ -97,6 +97,7 @@ Incorporated feed back about unclear doc > <ul> > <li><bug>61056</bug>HTTP : Support brotli decoding</li> > <li><bug>61135</bug>CookieManager : Drop Implementation select box > and cleanup class</li> > + <li>Test Script Recorder : enable proxy restart when prefix is > modified</li> > </ul> > > <h3>Other samplers</h3> > > > -- Cordialement. Philippe Mouawad.
