On Tue, Oct 3, 2017 at 1:02 PM, sebb <[email protected]> wrote: > On 3 October 2017 at 11:55, Emilian Bold <[email protected]> wrote: > >> Correct me if I am wrong, if we plan to include the code of one of those > > plugins, I don't see how we could without it being donated. > > > > Just like any dependency. I don't believe it's a rule that dependencies > > have to be binary JARs. A "work" being "included" could mean source code, > > not just compiled JAR. > > > >> If we are only including the binaries, then I don't see any benefit from > > it, as it is already a plugin. > > > > Having something included in JMeter proper would at least guarantee some > > stability and security wrt the code. > > > > A 3rd party plugin has no such guarantees. I personally don't like > hunting > > down plugins for my tools especially when it's not something niche. > > > > I don't believe JMeter should encourage users to always use plugins; is > > JMeter something usable out of the box or just a platform? > > > > I would gladly drop JDBC/MongoDB/JMS to have everything HTTP-related > > included. > > I think people are conflating different things here. > > JMeter does not include implementations of JDBC or JMS - or HTTP 1 for > that matter. > > IMO protocol implementations are outside the scope of JMeter. >
Yes, but using protocol clients for Load Testing those protocols is in JMeter scope. And HTTP2 is clearly one, it cannot be a plugin. > > > --emi > > > > On Tue, Oct 3, 2017 at 1:41 PM, sebb <[email protected]> wrote: > > > >> If the code is available as a plugin then I don't see the need to > >> include it in JMeter itself. > >> It can be listed on a plugins page on the Wiki. > >> > >> Remember that code that is added to the JMeter code base adds to the > >> ongoing maintenance cost. > >> This reduces the time that can be spent on the rest of the JMeter code. > >> > >> On 3 October 2017 at 11:27, Philippe Mouawad > >> <[email protected]> wrote: > >> > Hi Emilian, > >> > Correct me if I am wrong, if we plan to include the code of one of > those > >> > plugins, I don't see how we could without it being donated. > >> > I am not even sure that this project would be willing to donate it. > >> > > >> > If we are only including the binaries, then I don't see any benefit > from > >> > it, as it is already a plugin. > >> > > >> > Maybe before going further, we should review the code to see if it is > >> worth > >> > the discussion. > >> > > >> > Then we can ask Legal team, or feel free to ask. > >> > > >> > Regards > >> > > >> > On Tue, Oct 3, 2017 at 12:22 PM, Emilian Bold <[email protected] > > > >> > wrote: > >> > > >> >> IP clearance applies to donated code which will have an ASF license > >> header. > >> >> > >> >> For dependencies and included works this might help: > >> >> https://www.apache.org/legal/resolved.html#category-a > >> >> > >> >> FOR THE PURPOSES OF BEING INCLUDED IN AN APACHE PRODUCT, WHICH > LICENSES > >> >>> ARE CONSIDERED TO BE SIMILAR IN TERMS TO THE APACHE LICENSE 2.0? > >> >>> Works under the following licenses may be included within Apache > >> products: > >> >>> > >> >> > >> >> > >> >> Apache License 2.0 > >> >> > >> >> > >> >> Please ask Apache legal because I don't believe there are any > >> restrictions. > >> >> > >> >> > >> >> > >> >> --emi > >> >> > >> >> On Tue, Oct 3, 2017 at 12:49 PM, UBIK LOAD PACK Support < > >> >> [email protected]> wrote: > >> >> > >> >>> Hello, > >> >>> See: > >> >>> > >> >>> - https://incubator.apache.org/guides/ip_clearance.html > >> >>> > >> >>> Regards > >> >>> > >> >>> On Tuesday, October 3, 2017, Antonio Gomes Rodrigues < > [email protected] > >> > > >> >>> wrote: > >> >>> > >> >>> > Hi, > >> >>> > > >> >>> > I'm also curious about why we could not integrate apache licensed > >> code. > >> >>> I > >> >>> > was thinking we can fork a plugin and integrate it in JMeter. > >> >>> > > >> >>> > Anybody have an idea? > >> >>> > > >> >>> > Antonio > >> >>> > > >> >>> > 2017-10-02 21:25 GMT+02:00 Philippe Mouawad < > >> [email protected] > >> >>> > <javascript:;>>: > >> >>> > > >> >>> > > On Mon, Oct 2, 2017 at 9:21 PM, Emilian Bold < > >> [email protected] > >> >>> > <javascript:;>> > >> >>> > >> >>> > > wrote: > >> >>> > > > >> >>> > > > > AFAIK, unless the project donates their code to JMeter, we > >> cannot > >> >>> > take > >> >>> > > it > >> >>> > > > as it would be a license infringement at minimum. > >> >>> > > > > >> >>> > > > It's open source under the Apache 2.0 license. The license > itself > >> >>> > allows > >> >>> > > > you to bundle it with JMeter proper. Of course, it won't be > >> owned by > >> >>> > the > >> >>> > > > ASF but you can have it as a dependency. > >> >>> > > > > >> >>> > > > You could also "fork" it (or "vendor" it) if you want to add > some > >> >>> > > patches. > >> >>> > > > > >> >>> > > > >> >>> > > AFAIK, we need for this the owner to make a donation as piece of > >> code > >> >>> is > >> >>> > > important. > >> >>> > > There is IP clearance process at Apache for that. I doubt that > we > >> can > >> >>> > take > >> >>> > > it as is or fork it, but I'm not an expert in those matters. > >> >>> > > Maybe Andrei can tell us more. > >> >>> > > > >> >>> > > > >> >>> > > > >> >>> > > > Have there been any talks with CA Technologies / Blazemeter to > >> >>> perhaps > >> >>> > > > donate the plugin to the ASF? > >> >>> > > > > >> >>> > > > > Would you like to work on its implementation ? > >> >>> > > > > >> >>> > > > Why would I do that when you have this plugin available under > a > >> >>> > > compatible > >> >>> > > > license as well as this other one > >> >>> > > > https://github.com/syucream/jmeter-http2-plugin under Apache > 2.0 > >> >>> based > >> >>> > > on > >> >>> > > > netty? > >> >>> > > > > >> >>> > > I tested this one, it does not work very well. > >> >>> > > Looks more like a POC than a stable implementation. > >> >>> > > > >> >>> > > > >> >>> > > > >> >>> > > > > >> >>> > > > > >> >>> > > > --emi > >> >>> > > > > >> >>> > > > On Mon, Oct 2, 2017 at 10:11 PM, Philippe Mouawad < > >> >>> > > > [email protected] <javascript:;>> wrote: > >> >>> > > > > >> >>> > > > > Hi Emilian, > >> >>> > > > > AFAIK, unless the project donates their code to JMeter, we > >> cannot > >> >>> > take > >> >>> > > it > >> >>> > > > > as it would be a license infringement at minimum. > >> >>> > > > > > >> >>> > > > > Regarding HTTP2 there are many options AFAIK: > >> >>> > > > > > >> >>> > > > > - Jetty > >> >>> > > > > - Netty > >> >>> > > > > - HC5 > >> >>> > > > > > >> >>> > > > > Would you like to work on its implementation ? > >> >>> > > > > > >> >>> > > > > > >> >>> > > > > Regards > >> >>> > > > > > >> >>> > > > > On Mon, Oct 2, 2017 at 8:54 PM, Emilian Bold < > >> >>> [email protected] > >> >>> > <javascript:;>> > >> >>> > > > > wrote: > >> >>> > > > > > >> >>> > > > > > Hello, > >> >>> > > > > > > >> >>> > > > > > I see we have a HTTP2 plugin > >> >>> > > > > > https://github.com/Blazemeter/jmeter-bzm-plugins based on > >> the > >> >>> > Jetty > >> >>> > > > > HTTP2 > >> >>> > > > > > support and under an Apache 2.0 license. > >> >>> > > > > > > >> >>> > > > > > Is there any reason JMeter could not bless this > >> implementation > >> >>> and > >> >>> > > > bundle > >> >>> > > > > > it? > >> >>> > > > > > > >> >>> > > > > > --emi > >> >>> > > > > > > >> >>> > > > > > >> >>> > > > > > >> >>> > > > > > >> >>> > > > > -- > >> >>> > > > > Cordialement. > >> >>> > > > > Philippe Mouawad. > >> >>> > > > > > >> >>> > > > > >> >>> > > > >> >>> > > > >> >>> > > > >> >>> > > -- > >> >>> > > Cordialement. > >> >>> > > Philippe Mouawad. > >> >>> > > > >> >>> > > >> >>> > >> >>> > >> >>> -- > >> >>> > >> >>> Regards > >> >>> Ubik Load Pack <http://ubikloadpack.com> Team > >> >>> Follow us on Twitter <http://twitter.com/ubikloadpack> > >> >>> > >> >>> > >> >>> Cordialement > >> >>> L'équipe Ubik Load Pack <http://ubikloadpack.com> > >> >>> Suivez-nous sur Twitter <http://twitter.com/ubikloadpack> > >> >>> > >> >> > >> >> > >> > > >> > > >> > -- > >> > Cordialement. > >> > Philippe Mouawad. > >> > Ubik-Ingénierie > >> > > >> > UBIK LOAD PACK Web Site <http://www.ubikloadpack.com/> > >> > > >> > UBIK LOAD PACK on TWITTER <https://twitter.com/ubikloadpack> > >> > -- Cordialement. Philippe Mouawad.
