Github user ham1 commented on the issue:
https://github.com/apache/jmeter/pull/324
@pmouawad Thank you for committing my changes - in future I'm happy to
rebase and fix merge issues so you don't have to :)
There were only a few minor things:
- formatting of streams api code - they seem to be mostly on one line,
whereas I think they read much better when split, (perhaps this is the eclipse
formatter?)
- some extra whitespace was added (maybe eclipse settings?)
- I question the JavaDoc on the private methods - it didn't seem to help, I
had hoped the method name was sufficient - is there a reason it was added?
- formatting of JavaDoc comments, I think we should agree on a format and
make sure it's updated in the style guide on the wiki as we currently have a
mix and it would be good to agree to prevent further inconsistency (the
location of the description of the param, same or new line)
What's the best way for me to provide these changes? Force push to this PR,
new PR, email patch file?
Thanks
---
