Hi all,

a few questions on the extract method.

Does it have to be public? It seems to be called in extractMatchingStrings, only.

If it stays public, shouldn't it have tests?

Is the condition "matchNumber <= 0 || newFound != matchNumber" the correct one? What happens when found is given with a number bigger than matchNumber? Should we collect all matches? I think this should be "newFound < matchNumber", that way we extract at most matchNumber (-1) fragments.

Felix

Reply via email to