On 22 December 2017 at 12:02, Felix Schumacher <[email protected]> wrote: > Am 10.12.2017 um 12:36 schrieb Felix Schumacher: >> >> Am 01.12.2017 um 22:42 schrieb [email protected]: >>> >>> Author: pmouawad >>> Date: Fri Dec 1 21:42:50 2017 >>> New Revision: 1816913 >>> >>> URL: http://svn.apache.org/viewvc?rev=1816913&view=rev >>> Log: >>> Default Language has accidentally switched to english on Windows in 3.3 >>> >>> Modified: >>> jmeter/trunk/bin/jmeter >>> jmeter/trunk/bin/jmeter.bat >>> >>> Modified: jmeter/trunk/bin/jmeter >>> URL: >>> http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter?rev=1816913&r1=1816912&r2=1816913&view=diff >>> >>> ============================================================================== >>> --- jmeter/trunk/bin/jmeter (original) >>> +++ jmeter/trunk/bin/jmeter Fri Dec 1 21:42:50 2017 >>> @@ -122,6 +122,9 @@ esac >>> # system's memory availability: >>> HEAP="-Xms512m -Xmx512m -XX:MaxMetaspaceSize=256m" >>> +# Set language >>> +# LANGUAGE="-Duser.language=en -Duser.region=EN" >> >> >> On my ubuntu setup the variable LANGUAGE is set to "de:en", which will >> break the startup of JMeter. >> >> It might be better to use some other variable name.
Agreed; scripts should be careful not to use variable names that might clash with standard shell ones (unless of course they are doing so deliberately, e.g. by updating PATH) >> >> Felix > > Reposting as my original mail went to [email protected]. > > > Felix > >> >>> + >>> # Uncomment this to generate GC verbose file with Java prior to 9 >>> # VERBOSE_GC="-verbose:gc -Xloggc:gc_jmeter_%p.log -XX:+PrintGCDetails >>> -XX:+PrintGCCause -XX:+PrintTenuringDistribution -XX:+PrintHeapAtGC >>> -XX:+PrintGCApplicationConcurrentTime -XX:+PrintAdaptiveSizePolicy >>> -XX:+PrintGCApplicationStoppedTime -XX:+PrintGCDateStamps" >>> @@ -141,6 +144,6 @@ DUMP="-XX:+HeapDumpOnOutOfMemoryError" >>> SYSTEM_PROPS="-Djava.security.egd=file:/dev/urandom" >>> SERVER="-server" >>> -ARGS="$SERVER $DUMP $HEAP $VERBOSE_GC $GC_ALGO $SYSTEM_PROPS >>> $RUN_IN_DOCKER" >>> +ARGS="$SERVER $DUMP $HEAP $VERBOSE_GC $GC_ALGO $SYSTEM_PROPS $LANGUAGE >>> $RUN_IN_DOCKER" >>> "$JAVA_HOME/bin/java" $ADD_MODS $ARGS $JVM_ARGS $JMETER_OPTS -jar >>> "$PRGDIR/ApacheJMeter.jar" "$@" >>> >>> Modified: jmeter/trunk/bin/jmeter.bat >>> URL: >>> http://svn.apache.org/viewvc/jmeter/trunk/bin/jmeter.bat?rev=1816913&r1=1816912&r2=1816913&view=diff >>> >>> ============================================================================== >>> --- jmeter/trunk/bin/jmeter.bat (original) >>> +++ jmeter/trunk/bin/jmeter.bat Fri Dec 1 21:42:50 2017 >>> @@ -27,7 +27,7 @@ rem >>> rem ===================================================== >>> setlocal >>> -set JVM_ARGS=-Duser.language="en" -Duser.region="EN" >>> +rem set JVM_ARGS=-Duser.language="en" -Duser.region="EN" >>> rem Minimal version to run JMeter >>> set MINIMAL_VERSION=1.8.0 >>> >>> >> >
