We should also add integration tests that start jmeter using .sh/.bat (and mirror) to avoid issues like this one and the missing add-module on .bat
Regards On Sunday, February 4, 2018, sebb <seb...@gmail.com> wrote: > It also might make sense to add a unit test to check the versions > against the build.properties file > > On 4 February 2018 at 12:49, Milamber <milam...@apache.org> wrote: > > > > Would be better if the version number uses a variable in the top of file? > > > > > > On 04/02/2018 10:39, fschumac...@apache.org wrote: > >> > >> Author: fschumacher > >> Date: Sun Feb 4 09:39:05 2018 > >> New Revision: 1823083 > >> > >> URL: http://svn.apache.org/viewvc?rev=1823083&view=rev > >> Log: > >> Update classpath in mirror-server scripts to reflect log4j updates. > >> > >> Followup to r1821929 > >> > >> Modified: > >> jmeter/trunk/bin/mirror-server.cmd > >> jmeter/trunk/bin/mirror-server.sh > >> > >> Modified: jmeter/trunk/bin/mirror-server.cmd > >> URL: > >> http://svn.apache.org/viewvc/jmeter/trunk/bin/mirror- > server.cmd?rev=1823083&r1=1823082&r2=1823083&view=diff > >> > >> ============================================================ > ================== > >> --- jmeter/trunk/bin/mirror-server.cmd (original) > >> +++ jmeter/trunk/bin/mirror-server.cmd Sun Feb 4 09:39:05 2018 > >> @@ -26,8 +26,8 @@ set JMETER_CMD_LINE_ARGS=%* > >> cd /D %~dp0 > >> set > >> CP=..\lib\ext\ApacheJMeter_http.jar;..\lib\ext\ > ApacheJMeter_core.jar;..\lib\jorphan.jar;..\lib\oro-2.0.8.jar > >> -set > >> CP=%CP%;..\lib\slf4j-api-1.7.25.jar;..\lib\jcl-over-slf4j- > 1.7.25.jar;..\lib\log4j-slf4j-impl-2.8.2.jar > >> -set > >> CP=%CP%;..\lib\log4j-api-2.8.2.jar;..\lib\log4j-core-2.8.2. > jar;..\lib\log4j-1.2-api-2.8.2.jar > >> +set > >> CP=%CP%;..\lib\slf4j-api-1.7.25.jar;..\lib\jcl-over-slf4j- > 1.7.25.jar;..\lib\log4j-slf4j-impl-2.10.0.jar > >> +set > >> CP=%CP%;..\lib\log4j-api-2.10.0.jar;..\lib\log4j-core-2.10. > 0.jar;..\lib\log4j-1.2-api-2.10.0.jar > >> java -cp %CP% org.apache.jmeter.protocol. > http.control.HttpMirrorServer > >> %JMETER_CMD_LINE_ARGS% > >> > >> Modified: jmeter/trunk/bin/mirror-server.sh > >> URL: > >> http://svn.apache.org/viewvc/jmeter/trunk/bin/mirror- > server.sh?rev=1823083&r1=1823082&r2=1823083&view=diff > >> > >> ============================================================ > ================== > >> --- jmeter/trunk/bin/mirror-server.sh (original) > >> +++ jmeter/trunk/bin/mirror-server.sh Sun Feb 4 09:39:05 2018 > >> @@ -21,7 +21,7 @@ > >> cd "$(dirname "$0")" || exit 1 > >> > >> CP=../lib/ext/ApacheJMeter_http.jar:../lib/ext/ > ApacheJMeter_core.jar:../lib/jorphan.jar:../lib/oro-2.0.8.jar > >> > >> -CP=${CP}:../lib/slf4j-api-1.7.25.jar:../lib/jcl-over- > slf4j-1.7.25.jar:../lib/log4j-slf4j-impl-2.8.2.jar > >> > >> -CP=${CP}:../lib/log4j-api-2.8.2.jar:../lib/log4j-core-2.8. > 2.jar:../lib/log4j-1.2-api-2.8.2.jar > >> > >> +CP=${CP}:../lib/slf4j-api-1.7.25.jar:../lib/jcl-over- > slf4j-1.7.25.jar:../lib/log4j-slf4j-impl-2.10.0.jar > >> > >> +CP=${CP}:../lib/log4j-api-2.10.0.jar:../lib/log4j-core-2. > 10.0.jar:../lib/log4j-1.2-api-2.10.0.jar > >> java -cp $CP org.apache.jmeter.protocol. > http.control.HttpMirrorServer > >> "$@" > >> > >> > >> > > > -- Cordialement. Philippe Mouawad. Ubik-Ingénierie UBIK LOAD PACK Web Site <http://www.ubikloadpack.com/> UBIK LOAD PACK on TWITTER <https://twitter.com/ubikloadpack>
