I initially thought it could reset the keepAlive settings on Sampler but it's not the case. So it finally looks good to me
On Tue, Dec 18, 2018 at 6:18 PM Philippe Mouawad <[email protected]> wrote: > I think this is wrong > Will revert it > > On Tuesday, December 18, 2018, <[email protected]> wrote: > >> Author: pmouawad >> Date: Tue Dec 18 15:54:07 2018 >> New Revision: 1849188 >> >> URL: http://svn.apache.org/viewvc?rev=1849188&view=rev >> Log: >> Bug 63015 - Abnormal NoHttpResponseException when running request through >> proxy HTTP(S) Test Script Recorder after a first failing request >> >> Contributed by Ubik Load Pack support >> Bugzilla Id: 63015 >> >> Modified: >> >> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/Proxy.java >> jmeter/trunk/xdocs/changes.xml >> >> Modified: >> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/Proxy.java >> URL: >> http://svn.apache.org/viewvc/jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/Proxy.java?rev=1849188&r1=1849187&r2=1849188&view=diff >> >> ============================================================================== >> --- >> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/Proxy.java >> (original) >> +++ >> jmeter/trunk/src/protocol/http/org/apache/jmeter/protocol/http/proxy/Proxy.java >> Tue Dec 18 15:54:07 2018 >> @@ -221,7 +221,7 @@ public class Proxy extends Thread { >> >> samplerCreator = SAMPLERFACTORY.getSamplerCreator(request, >> pageEncodings, formEncodings); >> sampler = samplerCreator.createAndPopulateSampler(request, >> pageEncodings, formEncodings); >> - >> + sampler.setUseKeepAlive(false); >> /* >> * Create a Header Manager to ensure that the browsers >> headers are >> * captured and sent to the server >> @@ -233,6 +233,7 @@ public class Proxy extends Thread { >> if (isDebug) { >> log.debug("{} Execute sample: {} and url {}",port, >> sampler.getMethod(), sampler.getUrl()); >> } >> + >> result = sampler.sample(); >> >> // Find the page encoding and possibly encodings for forms >> in the page >> >> Modified: jmeter/trunk/xdocs/changes.xml >> URL: >> http://svn.apache.org/viewvc/jmeter/trunk/xdocs/changes.xml?rev=1849188&r1=1849187&r2=1849188&view=diff >> >> ============================================================================== >> --- jmeter/trunk/xdocs/changes.xml [utf-8] (original) >> +++ jmeter/trunk/xdocs/changes.xml [utf-8] Tue Dec 18 15:54:07 2018 >> @@ -154,6 +154,7 @@ of previous time slot as a base. Startin >> <li><bug>62940</bug>Use different <code>cn</code> and type of SAN >> extension when we are generating certificates based on IP addresses.</li> >> <li><bug>62916</bug>HTTP Test Script Recorder fails with >> UnsupportedOperationException if recording is started after a distributed >> test has been run</li> >> <li><bug>62987</bug>A TestBean element under HTTP(S) Test Script >> recorder does not work. Contributed by Ubik Load Pack (support at >> ubikloadpack.com)</li> >> + <li><bug>62987</bug>Abnormal NoHttpResponseException when running >> request through proxy HTTP(S) Test Script Recorder after a first failing >> request. Contributed by Ubik Load Pack (support at ubikloadpack.com)</li> >> </ul> >> >> <h3>Other Samplers</h3> >> >> >>
