Am 20.02.19 um 21:16 schrieb Philippe Mouawad:
On Wednesday, February 20, 2019, Vladimir Sitnikov <
sitnikov.vladi...@gmail.com> wrote:
Felix>I think we had this kind of error not long ago with another new
contributor
I agree.
Using Maven or Gradle would provide much better experience to new comers.
And using maven would also simplify our build, I guess Gradle would also
but I don’t know it enough to tell.
I think we could much better developer experience if we update to Gradle.
Is there a reason we can't use Gradle for build scripts?
No reason except time and volunteers.
If you’re willing to do it, I’ll be more than happy .
We have one long standing contribution that we didn't integrate (yet)
from Emilian Bold. He started to migrate the layout of our source code
to be more friendly to netbeans. I think it was the layout that is used
for maven/gradle, too. So we could start by moving our layout and then
try to setup gradle or maven.
But this should probably be discussed in another thread.
Felix
Regarding org.apache.jmeter.resources.PackageTest: its code is somewhat
obscure.
1) It prints violations to System.out.println, and it always fails
with "One or more subtests failed" error.
That is extremely confusing as it says "something is broken", and it
provides no clue.
I think its failures would be much simpler to understand if it just
collected all failures to a single string.
2) It tries to access user.dir for unknown reason. So when I start the
test from within IDEA, it fails with
junit.framework.AssertionFailedError: Not a directory:
/Users/vladimirsitnikov/Documents/code/src
at junit.framework.Assert.fail(Assert.java:57)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertNotNull(Assert.java:256)
at junit.framework.TestCase.assertNotNull(TestCase.java:426)
at org.apache.jmeter.resources.PackageTest.findFile(PackageTest.java:268)
at org.apache.jmeter.resources.PackageTest.getResources(
PackageTest.java:241)
at org.apache.jmeter.resources.PackageTest.<clinit>(PackageTest.java:232)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(
NativeMethodAccessorImpl.java:62)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(
DelegatingMethodAccessorImpl.java:43)
at java.lang.reflect.Method.invoke(Method.java:498)
at org.junit.internal.runners.SuiteMethod.testFromSuiteMethod(
SuiteMethod.java:35)
at org.junit.internal.runners.SuiteMethod.<init>(SuiteMethod.java:24)
Vladimir
