On Sun, 10 Mar 2019 at 15:13, Vladimir Sitnikov
<[email protected]> wrote:
>
> sebb> Could not find implementation class
> 'org.apache.jmeter.build.WitnessPlugin'
>
> I've corrected that.
> Basically I renamed org.apache.jmeter.build => org.apache.jmeter.buildtools.
>
> The not so funny thing is it was caused by unfortunate naming for the package.
> Initially I placed the code right into
> "org.apache.jmeter.WitnessPlugin", however then I decided
> "org.apache.jmeter.build"
> should be better package name for the tool.
> Unfortunately, it was killed by "build/" entry in ".gitignore" file
> which basically kills all the build directories at all the levels.

Huh?

I thought .gitignore entries were matched relative to the .gitignore file?
That's what this page says:

https://git-scm.com/docs/gitignore

> In rat-excludes.txt I used a bit more defensive approach like
> "src/*/build/**" so it doesn't accidentally skip rat.
>
> However I think this "build" item is a minor one (hope it was the last
> time we run into that), so we can reiterate on .gitignore later.

Must certainly check that it does not exclude more that necessary.

> Vladimir

Reply via email to