On Mon, 27 May 2019 at 20:11, Vladimir Sitnikov <[email protected]> wrote: > > sebb> -1 > sebb> I object to combining the move to Git with a move to Gradle. > > Please check https://www.apache.org/foundation/voting.html > asf>To prevent vetos from being used capriciously, they > asf>must be accompanied by a technical justification > asf>showing why the change is bad (opens a security exposure, negatively > affects performance, etc. ). > asf>*A veto without a justification is invalid and has no weight.* > > Could you please provide a technical justification?
Because it is harder to review. > I can easily do the change in two steps (migrate to Git first, then add > Gradle) Great, so let's do that. > however I'm sure that two-step process would be harder to review. How so? Surely it's easier to review multiple small steps than one large step. As I recall, Gradle requires multiple changes to the current layout, so doing Git+Gradle together would make it much harder to check that the SVN-Git conversion has worked. > Note: Ant build is tied to SVN, and I see no reasons to spend time on > implementing Ant+Git. The Ant build works fine without SVN, otherwise it would not be possible for end-users to build from a source archive. I've just tried running the Ant build in a clone of https://github.com/apache/jmeter.git and it works fine. There may be some release-specific targets that expect SVN, but as far as I recall, you can define properties to emulate the info that SVN would provide. > Note: https://github.com/vlsi/jmeter-git-cleanup-result is the suggested > Git repository. It is basically a SVN mirror with certain big objects > removed (to reduce repository bloat). > "jmeter-git-cleanup-result" has been around for quite a while, and I did > not receive much feedback. > > Vladimir
