-1 [X] Please keep "merge commit" button in GitHub UI because: - we’re adults and know what we are doing - we have power with github, why start lowering it - we don’t have enough feedback to decide. 1 PR merge did not respect this but with 0 impact
Regards On Monday, June 17, 2019, Vladimir Sitnikov <[email protected]> wrote: > Hi, > > We have migrated to GitBox, and now committers have enough grants to merge > PRs right from GitHub UI. > With great power comes great responsibility. > > Unfortunately, the button defaults to "create merge commit". > It makes Git history non-linear which might be painful to analyze. > Non-linear histories might be helpful, however I think we don't really need > those from GitHub UI. > > Other options are > "squash and merge" (==pretend the PR was developed as a single commit on > top of the current master) > "rebase and merge" (==pretend all the commits in PR were developed on top > of the current master) > > Both options more or less resemble the way we used to work with SVN. > "Create merge commit from GitHub UI" is something new, and I suggest to > disable it. > Note: merge commits could still be created though command line, and it is a > completely different topic. > > I suggest to make a formal vote about it: > > +1 [ ] Let's disable "merge commit" button in GitHub UI > +0 [ ] I don't care, but it is fine > -1 [ ] Please keep "merge commit" button in GitHub UI because... > > My vote is > +1 Let's disable "merge commit" button in GitHub UI > > Vladimir > -- [image: logo Ubik Ingenierie] <https://www.ubik-ingenierie.com> Philippe Mouawad Senior Performance Expert 320914981 <+33320914981> | [email protected] [image: ubik-ingenierie.com] ubik-ingenierie.com <https://www.ubik-ingenierie.com> | [image: 03.20.91.49.81] 03.20.91.49.81 <+33320914981> | [image: 23 rue du chemin de fer , 59100 , Roubaix] 23 rue du chemin de fer, 59100, Roubaix <https://www.openstreetmap.org/#map=18/50.69454/3.16455>
