I am against too much rules for PR.
It might discourage contributions.

A sufficient minimum for me is:

   - JUnit
   - Documentation
   - Checkstyle (but I am ok to fix it)

What we can do is document in Contribute , how to do it without making it
mandatory


On Tue, Jul 2, 2019 at 10:16 PM Vladimir Sitnikov <
[email protected]> wrote:

> Philippe> [apache/jmeter] This implements "Provide ability to configure
> whether a new iteration is a new user or same user" (BUG 62861) (#470)
> (629c643)
>
> I wonder if we should implement a check for "underoptimized pngs" in the
> PRs.
> png volume towards JMeter download size which is not that good.
>
> Vladimir
>


-- 
Cordialement.
Philippe Mouawad.

Reply via email to