>No, it's one of my concern but that's not what drives my commit. >The Pom are wrong and I am trying to fix it.
That is fine. However, this time the fix is wrong, so I suggest to step back and revert it. >Can you explain instead of requesting revert ? Simple explanation: Gradle builds the code, and the resulting binary works. It means all the required jars are declared (either explicitly or they come with transitive dependencies) xpp3 is not used by JMeter code, so the library should not be in the dependencies. In other words, org.xmlpull classes never appear in the source code of JMeter, so the library should not be in the dependencies. As you can see below, xpp3 is used by xtream:jar, and it is declared in the pom file for com.thoughtworks.xstream:xstream:jar:1.4.11 (see https://repo1.maven.org/maven2/com/thoughtworks/xstream/xstream/1.4.11.1/xstream-1.4.11.1.pom ) $ mvn -f src/core/build/publications/core/pom-default.xml dependency:tree [INFO] --- maven-dependency-plugin:2.8:tree (default-cli) @ ApacheJMeter_core --- [INFO] org.apache.jmeter:ApacheJMeter_core:jar:5.2.1-SNAPSHOT [INFO] +- org.apache.jmeter:ApacheJMeter:jar:5.2.1-SNAPSHOT:compile [INFO] +- org.apache.jmeter:jorphan:jar:5.2.1-SNAPSHOT:compile [INFO] | +- org.slf4j:slf4j-api:jar:1.7.28:compile [INFO] | +- commons-io:commons-io:jar:2.6:runtime [INFO] | \- org.apache.commons:commons-lang3:jar:3.9:runtime [INFO] +- bsf:bsf:jar:2.4.0:compile [INFO] | \- commons-logging:commons-logging:jar:1.0.4:compile [INFO] +- com.fifesoft:rsyntaxtextarea:jar:3.0.4:compile [INFO] +- net.sf.jtidy:jtidy:jar:r938:compile [INFO] +- com.thoughtworks.xstream:xstream:jar:1.4.11:compile [INFO] | +- xmlpull:xmlpull:jar:1.1.3.1:compile [INFO] | \- xpp3:xpp3_min:jar:1.1.4c:compile ^^^ here [INFO] +- org.apache.logging.log4j:log4j-1.2-api:jar:2.12.1:compile [INFO] +- org.apache.logging.log4j:log4j-api:jar:2.12.1:compile [INFO] +- org.apache.logging.log4j:log4j-core:jar:2.12.1:compile [INFO] +- org.apache.logging.log4j:log4j-slf4j-impl:jar:2.12.1:compile [INFO] +- org.apiguardian:apiguardian-api:jar:1.1.0:compile [INFO] +- oro:oro:jar:2.0.8:compile [INFO] +- xalan:xalan:jar:2.7.2:compile [INFO] | \- xalan:serializer:jar:2.7.2:compile [INFO] +- net.sf.saxon:Saxon-HE:jar:9.9.1-5:compile [INFO] +- org.slf4j:jcl-over-slf4j:jar:1.7.28:runtime [INFO] +- commons-codec:commons-codec:jar:1.13:runtime [INFO] +- commons-collections:commons-collections:jar:3.2.2:runtime [INFO] +- com.github.ben-manes.caffeine:caffeine:jar:2.8.0:runtime [INFO] | +- org.checkerframework:checker-qual:jar:2.10.0:runtime [INFO] | \- com.google.errorprone:error_prone_annotations:jar:2.3.3:runtime [INFO] +- com.fasterxml.jackson.core:jackson-annotations:jar:2.9.10:runtime [INFO] +- com.fasterxml.jackson.core:jackson-core:jar:2.9.10:runtime [INFO] +- com.fasterxml.jackson.core:jackson-databind:jar:2.9.10:runtime [INFO] +- com.miglayout:miglayout-swing:jar:5.2:runtime [INFO] | \- com.miglayout:miglayout-core:jar:5.2:runtime [INFO] +- org.freemarker:freemarker:jar:2.3.29:runtime [INFO] +- org.mozilla:rhino:jar:1.7.11:runtime [INFO] +- org.apache.xmlgraphics:xmlgraphics-commons:jar:2.3:runtime [INFO] +- org.apache.commons:commons-text:jar:1.8:runtime [INFO] +- org.apache.commons:commons-math3:jar:3.6.1:runtime [INFO] +- org.apache.tika:tika-core:jar:1.22:runtime [INFO] +- org.jodd:jodd-core:jar:5.0.13:runtime [INFO] +- org.jodd:jodd-props:jar:5.0.13:runtime [INFO] +- org.codehaus.groovy:groovy-all:jar:2.4.16:runtime [INFO] +- org.apache.tika:tika-parsers:jar:1.22:runtime [INFO] +- xerces:xercesImpl:jar:2.12.0:runtime [INFO] \- xml-apis:xml-apis:jar:1.4.01:runtime >http modules requires HttpClient, it's not referenced , as a > consequence corresponding pom is wrong See $ mvn -f src/protocol/http/build/publications/http/pom-default.xml dependency:tree ... [INFO] +- org.apache.httpcomponents:httpmime:jar:4.5.10:runtime [INFO] | \- org.apache.httpcomponents:httpclient:jar:4.5.10:runtime ... Vladimir
