Hi, In my opinion we need only 1 LaFs with different color themes
I vote response 3 Le jeu. 26 mars 2020 à 21:04, Vladimir Sitnikov <sitnikov.vladi...@gmail.com> a écrit : > Hi, > > We provide a menu option to select Look and Feel. > I'm not sure which of them are used often, however, multiple LaFs come at a > cost. > > For example, TCP Sampler UI > uses org.apache.jmeter.gui.util.TristateCheckBox which has multiple hacks > for different LaFs. > TristateCheckBox relies on defaults.get("CheckBox.icon") which is null in > case Daflkaf theme. > On top of that, it is hard to tell what the third state means. The UI is > obscure, and the documentation says nothing on the third state of the > checkbox. > > So I have a couple of questions: > 1) Should we replace TCP Sampler UI to use regular checkbox rather than a > tristate one? > 2) Should we refrain from implementing custom components? > I'm inclined to drop TristateCheckBox completely rather than trying to fix > that control to support the current LaFs. > In practice, it would take time to develop and test custom-painted UI > components across multiple looks. > 3) What if we reduce the number of LaFs that we "support"? I do not think > users really need different **styles** of UI. > It should be enough if we provide an option to use different color themes > like "light, dark, contrast, etc, etc". > > Vladimir >