weisJ opened a new pull request #599:
URL: https://github.com/apache/jmeter/pull/599


   ## Description
   Ensure all buttons added to the toolbar behave and look consistently.
   
   ## Motivation and Context
   Some plugins add own buttons to the toolbar e.g. JMeter Plugin.
   Because those most likely aren't configured the same way the other buttons 
are they look/feel out of place.
   This PR ensures that buttons in the toolbar are
   1. Non focusable.
   2. If a Darklaf theme is selected have their client properties set 
accordingly.
   
   Ideally there should be an API for plugin developers to add own buttons to 
the toolbar (Is there already?). Right now the icons are located at the end of 
the toolbar instead of the designated button area.
   
   ## How Has This Been Tested?
   See screenshots.
   
   ## Screenshots (if appropriate):
   Visually this only makes a difference with Darklaf.
   
   Before:
   
![toolbar_old](https://user-images.githubusercontent.com/31143295/85273933-8cd6fc80-b47e-11ea-824a-c76d320586e1.png)
   
   After:
   
![toolbar_new](https://user-images.githubusercontent.com/31143295/85273943-8fd1ed00-b47e-11ea-8670-8a4b818cfa5f.png)
   
   ## Types of changes
   - Visual changes.
   
   ## Checklist:
   - [x] My code follows the [code style][style-guide] of this project.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to