On Sun, Jun 28, 2020 at 11:51 AM Philippe Mouawad < [email protected]> wrote:
> Hello, > In PR 602 (https://github.com/apache/jmeter/pull/602) , we see that using > an Async Queue improves throughput. > > This approach would also benefit to Summarizer: > > - https://bz.apache.org/bugzilla/show_bug.cgi?id=64559 > > > But I wonder if we should not move the Queue inside ListenerNotifier , > this way: > > - all Listeners would benefit from this without further work > - All listeners would be called by a Single Threads allowing us to > simplify and improve performances of this code where we allocate too many > objects: > - CSVSaveService#StringQuoter => StringBuilder > > 1) Well, this benefit is not true in distributed tests with current state 2) ListenerNotifier would benefit from being a Singleton: - One instance is created in StandardEngine#run() used by all threads - But It is currently instantiated in TransactionController (this "hacky" class being the source of many problems in JMeter) > > What do you think ? > Thanks > -- > Regards > Philippe M. > > -- Cordialement Philippe M. Ubik-Ingenierie
