ham1 commented on a change in pull request #608:
URL: https://github.com/apache/jmeter/pull/608#discussion_r467487438
##########
File path:
src/components/src/main/java/org/apache/jmeter/visualizers/backend/SamplerMetric.java
##########
@@ -99,8 +99,9 @@ public static void setDefaultWindowMode(WindowMode
windowMode) {
/**
* Add a {@link SampleResult} to be used in the statistics
* @param result {@link SampleResult} to be used
+ * @param isCumulated is the overall Sampler Metric
*/
- public synchronized void add(SampleResult result) {
+ public synchronized void add(SampleResult result, boolean isCumulated) {
Review comment:
Could we use two separate methods instead of a boolean flag?
I think
`samplerMetric.add(sampleResult, false)`
`getSamplerMetric(CUMULATED_METRICS).add(sampleResult, true);`
isn't as readable as:
`samplerMetric.add(sampleResult)`
`getSamplerMetric(CUMULATED_METRICS).addCumulative(sampleResult);`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
