delirius325 opened a new pull request #615:
URL: https://github.com/apache/jmeter/pull/615


   ## Description
   After 3 years of developing and maintaining the ElasticSearch Backend 
Listener plugin for JMeter, I believe it's time for it to be integrated to the 
main codebase.
   
   * Added `org.apache.jmeter.visualizers.backend.elasticsearch` package
   * Added the following classes:
     * ElasticsearchBackendClient.java
     * ElasticsearchMetric.java
     * ElasticsearchMetricSender.java
     * ElasticsearchRequests.java
   * Added unit tests
     * TestElasticsearchBackend.java
   
   ## Motivation and Context
   As I mentioned above, after 3 years of developing, publishing and 
maintaining the plugin "Elasticsearch Backend Listener", I believe it is time 
for it to be added to the main codebase. As a result of this, Elasticsearch 
would officially be supported by JMeter and would evolve nicely with it. 
   
   It is clearly a used and needed integration since as it stands there are 
over 2500 users installing the plugin 
[source](https://jmeter-plugins.org/stats/). 
   
   ## How Has This Been Tested?
   The plugin itself has been tested through and through for over 3 years. As 
for how it's been tested in the main codebase; I've changed all the packages 
names, added the necessary dependencies in the `build.gradle.kts` of the 
`components` workspace. I have applied the necessary coding styles, corrected 
and adjusted if necessary.
   
   My testing environment consisted of the following:
   
   * locally built JMeter (5.3.1-SNAPSHOT + my code modifications)
   * ElasticSearch 7.9.0
   * Kibana 7.9.0
   
   To test, I built JMeter using `gw runGui`. I then added a sample `Thread 
Group` as well as `Debug samplers` and a `Backend Listener` to which I setup 
the config to point to my local ElasticSearch engine.
   I executed the test and verified that samples showed up.
   
   ## Screenshots
   ![Screen Shot 2020-09-01 at 3 14 00 
PM](https://user-images.githubusercontent.com/6709533/91896956-9ee7cf00-ec67-11ea-9965-df394d7b3096.png)
   ![Screen Shot 2020-09-01 at 3 17 22 
PM](https://user-images.githubusercontent.com/6709533/91896693-46b0cd00-ec67-11ea-91b4-05e8287ee87d.png)
   ![Screen Shot 2020-09-01 at 3 23 35 
PM](https://user-images.githubusercontent.com/6709533/91896695-47496380-ec67-11ea-88e3-bacef7e572cf.png)
   
   ## Types of changes
   - New feature (non-breaking change which adds functionality)
   
   ## Checklist:
   - [x] My code follows the [code style][style-guide] of this project.
   - [x] I have updated the documentation accordingly.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
[email protected]


Reply via email to