Hello, I've submitted a PR: https://github.com/apache/jmeter/pull/627 Please take a look.
Thanks in advance, Woonsan On Sun, Sep 20, 2020 at 5:14 PM Woonsan Ko <[email protected]> wrote: > > On Fri, Sep 18, 2020 at 4:02 PM Philippe Mouawad > <[email protected]> wrote: > > > > On Fri, Sep 18, 2020 at 4:39 PM Woonsan Ko <[email protected]> wrote: > > > > > Hello Philippe, > > > > > > On Fri, Sep 18, 2020 at 7:20 AM Philippe Mouawad > > > <[email protected]> wrote: > > > > > > > > Hello Woonsan, > > > > > > > > Thanks for your proposal and ideas. > > > > > > Great, thanks! :-) > > > > > > > Would you be ready to contribute to this ? > > > > > > Yes, I would. > > > > > > > What new dependencies will it bring on the project ? > > > > > > At this moment, I can just imagine that we could add one extending the > > > HTTP Request Sampler, probably only with a different UI - preset to > > > POST with the 2 textarea fields for the body json data, while leaving > > > the stored data structure as-is. > > > So, I guess we may use the existing library, json-smart, without > > > introducing any new dependency. > > > > > json-smart does not seem to be maintained , so if you have a better one, go > > for it. > > Thanks for the suggestion! > I think we might want to use gson because it's simple enough for our > use cases - just serialization and deserialization to/from string. > > Build fails when I just added > 'implementation("com.google.code.gson:gson")' in > src/protocol/build.gradle.kts and 'gson.version=2.8.6' in > gradle.properties. > Could someone give me a hint? > > Thanks in advance, > > Woonsan > > > > > > > > > Please share your insights otherwise. > > > > > > > Cheers, > > > > > > Woonsan > > > > > > > > > > > > > > > Regards > > > > > > > > On Fri, Sep 18, 2020 at 1:15 PM Woonsan Ko <[email protected]> wrote: > > > > > > > > > Hi, > > > > > > > > > > I have used HTTP Request sampler for GraphQL testing with setting > > > > > request body with escaped json strings like this: > > > > > > > > > > {"operationName":null,"variables":{},"query":"{\n fineSomethings(text: > > > > > \"\", offset: 0, limit: 200) {\n offset\n limit\n count\n total\n > > > > > items {\n ... }\n }\n }\n }\n}\n"} > > > > > > > > > > It is a bit harder to read and update than some graphql tools such as > > > > > graphql playground [1] which escapes graphql and variable json to an > > > > > escaped body under the hood. > > > > > So, I think it would be nice if we have a GraphQL Sampler with a > > > > > similar UI - separate graphql query or mutation input and variables > > > > > (json) input. > > > > > How does it sound? > > > > > > > > > > Regards, > > > > > > > > > > Woonsan > > > > > > > > > > [1] https://github.com/graphql/graphql-playground > > > > > > > > > > > > > > > > > -- > > > > Cordialement. > > > > Philippe Mouawad. > > > > > > > > > -- > > Cordialement. > > Philippe Mouawad.
