vlsi commented on pull request #632: URL: https://github.com/apache/jmeter/pull/632#issuecomment-713468232
> if it doesn't break the build when running with Java 8 All the previous CI jobs pass, so it works. In practice, it is activated only in case `-PenableErrorprone` is added as a command-line option or `gradle.properties` setting. > Could we add the feature (errorprone) without changing every nag it shows? Well, most of the warnings are true issues. There is an unfortunate case when the tool discourages the use of `Hashtable`, `Enumeration`, and `LinkedList` in the same check. Nobody uses `Hashtable` nowadays unless that is required for an ancient API, however, people can easily use `LinkedList` without realizing it is way slower and less efficient than `ArrayList` and `ArrayDeque` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
