Hello, I tried implementing it by modifying in those 2 methods the default value
- https://github.com/apache/jmeter/blob/master/src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java#L838 - https://github.com/apache/jmeter/blob/master/src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/sampler/HTTPSamplerBase.java#L846 But they are not taken into account, it looks like the method returns 0 because in this code: public int getPropertyAsInt(String key, int defaultValue) { JMeterProperty jmp = getRawProperty(key); => jmp is not NullProperty nor null, so jmp.getIntValue() is called leading to 0 return jmp == null || jmp instanceof NullProperty ? defaultValue : jmp.getIntValue(); } Is this another bug surfacing ? Regards On Sun, Dec 20, 2020 at 7:14 PM Antonio Gomes Rodrigues <[email protected]> wrote: > Hi > > +1 to me to put default timeout > > Le dim. 20 déc. 2020 à 18:44, Graham Russell <[email protected]> a écrit : > > > I agree, setting those as defaults is much better than infinite and less > > concerning than 10s/60s. > > > > They probably won't do much to stop people complaining about JMeter > hanging > > on shutdown, > > was this lack of default timeout the root cause of those complaints or is > > there something else we can do with that issue? > > > > On Sun, 20 Dec 2020, 13:02 Philippe Mouawad, <[email protected] > > > > wrote: > > > > > Hello, > > > Let’s do that > > > > > > Thanks for feedback > > > > > > On Sunday, December 20, 2020, Felix Schumacher < > > > [email protected]> wrote: > > > > > > > Am Samstag, den 19.12.2020, 17:10 +0100 schrieb Philippe Mouawad: > > > > > Hello > > > > > > > > > > Currently we don't set neither connect nor read timeout which means > > > > > they > > > > > default to infinite. > > > > > I don't think those are good defaults and users frequently think > > > > > JMeter is > > > > > hanging. > > > > > > > > > > Shouldn't we set better defaults ? > > > > > > > > > > - Connect to 10s > > > > > - Read to 60s > > > > > > > > I generally like the idea of setting a default timeout, as infinity > is > > > > a long time to wait for. The times are great, if you know, that > > > > timeouts are set, but what about the old settings, where the plan > > > > didn't take those into account? > > > > > > > > I think we can be a bit more generous on those timeouts, especially > for > > > > the read timeout. For a non-interactive site, those might be a bit > > > > short. > > > > > > > > In my firefox's about:config the values for connection and response > > > > timeout are 90 s and 300 s respectively. (I took > > > > network.http.connection-timeout and network.http.response.timeout) > > > > > > > > I think those values should be conservative enough for most of our > > > > users. > > > > > > > > > > > > Felix > > > > > > > > > > > > > > WDYT ? > > > > > Thanks > > > > > > > > > > > > > > -- > > > Cordialement. > > > Philippe Mouawad. > > > > > > -- Cordialement. Philippe Mouawad.
