woonsan commented on a change in pull request #651:
URL: https://github.com/apache/jmeter/pull/651#discussion_r596518987
##########
File path:
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/util/GraphQLRequestParamUtils.java
##########
@@ -79,27 +76,32 @@ public static boolean isGraphQLContentType(final String
contentType) {
* @throws RuntimeException if JSON serialization fails for some reason
due to any runtime environment issues
*/
public static String toPostBodyString(final GraphQLRequestParams params) {
- final ObjectMapper mapper = new ObjectMapper();
- final ObjectNode postBodyJson = mapper.createObjectNode();
- postBodyJson.set(OPERATION_NAME_FIELD,
-
JsonNodeFactory.instance.textNode(StringUtils.trimToNull(params.getOperationName())));
-
+ final StringBuilder result = new StringBuilder();
Review comment:
@FSchumacher , at a glance, a quick solution can be to move the
`Arguments` generation logic from `GraphQLUrlConfigGui` to
`HttpSamplerBase#getArgument()`. GraphQL query/mutation and variables can still
be stored during the configuration, but the http arguments are being generated
in `HttpSamplerBase#getArgument()` - in case the arguments are empty and
graphql params are set.
Am I in the right track?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
