vlsi commented on pull request #652: URL: https://github.com/apache/jmeter/pull/652#issuecomment-804119788
I think small cleanups like you proposed are worth doing, however, the codebase is huge, and it would be a disaster if you create 100500 pull requests like that. Migration from JUnit4 to JUnit5 APIs is welcome. It would be ok if you migrated, for example, "all try-catch => assertThrows within :core module". In other words, if you see there's something to be improved, it would be great to improve similar things at once instead of multiple pull requests with more-or-less the same changes. Note that "pull request created" and "pull request commented" triggers notifications for multiple developers who need to open the PR and check what is there. Please use that time wisely. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
