kiwi1969 opened a new pull request #654: URL: https://github.com/apache/jmeter/pull/654
## Description Fix erroneous warning message output when loading client cert from keystore with password in non-GUI mode, when password is actually present. Add extra condition for z/OS operating system, so warning message will appear if keystore password is ever null. Code changes made are : 1) Added specific rule for operating system = "z/OS", to force validation of password for keystore to be non-null (ie we are always forced to set a password in keytool when using z/OS). This will then trigger the warning message to appear if defaultpw = null. 2) method getPassword() incorrectly gives warning regarding no password provided, when running without GUI and password the is actually fine. ie It seems to be a prior coding error on placement of else statement. ## Motivation and Context Misleading error messages that confused debugging issues around keystore loading and jmeter configuration files ## How Has This Been Tested? Unit tested in own environment. ## Types of changes - Bug fix (non-breaking change which fixes an issue) - New feature (non-breaking change which adds functionality) ## Checklist: <!--- Go over all the following points, and put an `x` in all the boxes that apply. --> <!--- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] My code follows the [code style][style-guide] of this project. - [x] I have updated the documentation accordingly. [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
