woonsan commented on pull request #660: URL: https://github.com/apache/jmeter/pull/660#issuecomment-826311880
Thanks for the remarks! I fully understand the pointers and there must be better designs and solutions than this quick solution, indeed. Just two things though: - The solution includes re-formatting to remove unnecessary white spaces like most GraphQL clients does, and this is done by parsing and formatting through the Jackson library. This "re-formatting" can possibly be done in a different way, but I assume the current solution is simpler. - The prefix and suffix in the solution are not just simple prefix/suffix, but instead it's following the JSON Reference syntax pattern, which means it is very unlikely that GraphQL variable JSON data could possibly allow any JSON Reference at all, or even allowed in the future, it is very unlikely for users to refer to the "JMeter-specific" json object reference in GraphQL variables in reality. - Of course, JMeter is too flexible, so for that reason, I actually narrow down the scope only to numeric variable value expression in this solution, which I believe should be good enough practically. Regards, Woonsan -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org
