tilln commented on a change in pull request #664: URL: https://github.com/apache/jmeter/pull/664#discussion_r619735642
########## File path: bin/heapdump.cmd ########## @@ -20,5 +20,5 @@ rem Ask the JMeter client to perform a HeapDump rem P1 = command port for JMeter instance (defaults to 4445) -java -cp %~dp0ApacheJMeter.jar org.apache.jmeter.util.ShutdownClient HeapDump %* +java -cp "%~dp0"ApacheJMeter.jar org.apache.jmeter.util.ShutdownClient HeapDump %* Review comment: You're right. My mistake, sorry. (Mismatching commit and test). Thanks for double checking! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org