veselov opened a new pull request #669: URL: https://github.com/apache/jmeter/pull/669
## WiP STATUS - there don't seem to be any tests around the key manager at present, please see comment below - I'm not sure if this needs any documentation change, I don't think so, as it's just a bug fix. ## Description Fixes support for cases when the key type request to the key manager does not match the key type of the available keys. Without this fix, a key of incorrect type may be returned to the SSL engine, resulting in key misuse and connection failure. ## Motivation and Context https://bz.apache.org/bugzilla/show_bug.cgi?id=65461 ## How Has This Been Tested? The tests pass, and I tested this for my case specifically, but I don't see any unit test that exercise this code. Any pointers or suggestions on how to test this during build? The simplest would probably be to have a keystore and simulate calls to the key manager. ## Screenshots (if appropriate): ## Types of changes - Bug fix (non-breaking change which fixes an issue) ## Checklist: - [X] My code follows the [code style][style-guide] of this project. - [ ] I have updated the documentation accordingly. [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
