vlsi commented on a change in pull request #677:
URL: https://github.com/apache/jmeter/pull/677#discussion_r748907085
##########
File path:
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/Proxy.java
##########
@@ -89,6 +89,19 @@
private static final String SSLCONTEXT_PROTOCOL =
JMeterUtils.getPropDefault("proxy.ssl.protocol", "TLS"); //
$NON-NLS-1$ $NON-NLS-2$
+ private static final String PROTOCOL_LIST =
+ JMeterUtils.getPropDefault("https.socket.protocols", ""); //
$NON-NLS-1$ $NON-NLS-2$
+
+ private static final String CIPHER_SUITE_LIST =
+ JMeterUtils.getPropDefault("https.cipherSuites", ""); //
$NON-NLS-1$ $NON-NLS-2$
+
+ private static final String[] SUPPORTED_PROTOCOL_LIST =
Review comment:
The naming looks misleading.
What do you think if `String PROTOCOL_LIST` was named `String
HTTPS_SOCKET_PROTOCOLS`, and `String[] SUPPORTED_PROTOCOL_LIST` was `String[]
HTTPS_SOCKET_PROTOCOLS_ARRAY`?
On the other hand, it might make sense to add
`JMeterUtils.getArrayPropDefault` or something like that since it is probably
not the last time we have an array property. It would eliminate the need of
non-array field (so there would not be a need to invent a name for it)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
