pmouawad commented on a change in pull request #669:
URL: https://github.com/apache/jmeter/pull/669#discussion_r775913241
##########
File path:
src/core/src/main/java/org/apache/jmeter/util/keystore/JmeterKeyStore.java
##########
@@ -303,36 +323,60 @@ private boolean isIndexInConfiguredRange(int index) {
* @throws IllegalArgumentException if {@link #clientCertAliasVarName}
* is not empty and no key for this alias
could be found
*/
- public String getAlias() {
+ public String getAlias(String [] keyTypes) {
Review comment:
As @veselov explained, it implements the ability to test client
certificate authentication.
This feature is useful and needed, so maybe it requires refactoring but just
removing it is not acceptable.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
