FSchumacher commented on pull request #700:
URL: https://github.com/apache/jmeter/pull/700#issuecomment-1050225551
The following files are not done yet:
```console
$ find src -name "*.java" -exec grep -rl \.oro\. {} \; | while read i; do
grep -q use_java_regex $i || echo $i; done
src/core/src/main/java/org/apache/jmeter/util/JMeterUtils.java
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/util/accesslog/LogFilter.java
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/util/accesslog/SessionFilter.java
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/util/EncoderCache.java
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/parser/HtmlParsingUtils.java
src/functions/src/main/java/org/apache/jmeter/functions/EscapeOroRegexpChars.java
```
JMeterUtils, EncoderCache and EscapeOroRegexpChars are not problematic, as
they contain no (real) regex stuff.
LogFilter and SessionFilter have the Oro Regex API in their public API,
which would be hard to remove. Should we add new methods and deprecate the old
ones?
HtmlParsingUtils is a real bummer as it has the Oro stuff in its public API
and it is used in our code base:
```console
$ find src -name "*.java" -exec grep -rl HtmlParsingUtils {} \; | while read
i; do grep -q use_java_regex $i || echo $i; done
src/protocol/http/src/test/java/org/apache/jmeter/protocol/http/parser/TestHtmlParsingUtils.java
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/parser/JTidyHTMLParser.java
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/parser/HtmlParsingUtils.java
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/parser/LagartoBasedHtmlParser.java
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/parser/JsoupBasedHtmlParser.java
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/modifier/AnchorModifier.java
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
