vlsi commented on a change in pull request #700:
URL: https://github.com/apache/jmeter/pull/700#discussion_r817770045
##########
File path:
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/util/accesslog/SessionFilter.java
##########
@@ -86,6 +90,22 @@ protected boolean hasExcPattern(String text) {
}
protected String getIpAddress(String logLine) {
+ if (useJavaRegex) {
+ return getIpAddressWithJavaRegex(logLine);
+ }
+ return getIpAddressWithOroRegex(logLine);
+ }
+
+ private String getIpAddressWithJavaRegex(String logLine) {
+ java.util.regex.Pattern incIp =
JMeterUtils.compilePattern("\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}\\.\\d{1,3}");
Review comment:
It should probably be cached in a static final variable rather than via
an evictable cache.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
