QAInsights commented on a change in pull request #705:
URL: https://github.com/apache/jmeter/pull/705#discussion_r820104916
##########
File path: src/core/build.gradle.kts
##########
@@ -59,18 +59,20 @@ dependencies {
because("XPathUtil: throws SaxonApiException")
}
- runtimeOnly("org.codehaus.groovy:groovy") {
- because("Groovy is a default JSR232 engine")
+ runtimeOnly("org.apache.groovy:groovy") {
+ because("Groovy is a default JSR223 engine")
}
- arrayOf("dateutil", "datetime", "jmx", "json", "jsr223", "sql",
"templates").forEach {
- runtimeOnly("org.codehaus.groovy:groovy-$it") {
- because("Groovy is a default JSR232 engine")
+ arrayOf("dateutil", "datetime", "jmx", "json", "jsr223", "sql",
"templates","toml").forEach {
+ runtimeOnly("org.apache.groovy:groovy-$it") {
+ because("Groovy is a default JSR223 engine")
}
}
implementation("com.fasterxml.jackson.core:jackson-annotations")
implementation("com.fasterxml.jackson.core:jackson-core")
implementation("com.fasterxml.jackson.core:jackson-databind")
+ implementation("com.fasterxml.jackson.dataformat:jackson-dataformat-toml")
Review comment:
@vlsi Thanks for reviewing. Groovy 4.0.0 has TOML support(incubating
feature). I have also published a blog post about it. Please
[check](https://qainsights.com/working-with-toml-in-groovy-4-0-in-jmeter/).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
