FSchumacher commented on code in PR #717:
URL: https://github.com/apache/jmeter/pull/717#discussion_r913805737
##########
src/core/src/main/java/org/apache/jmeter/engine/StandardJMeterEngine.java:
##########
@@ -84,6 +91,14 @@ public class StandardJMeterEngine implements JMeterEngine,
Runnable {
/** Whether to call System.exit(0) unconditionally at end of non-GUI test
*/
private static final boolean SYSTEM_EXIT_FORCED =
JMeterUtils.getPropDefault("jmeterengine.force.system.exit", false);
+ /**
+ * Executor service to execute management tasks like "start test", "stop
test".
+ * The use of {@link ExecutorService} allows propagating the exception
from the threads.
+ */
+ private static final ExecutorService EXECUTOR_SERVICE =
Executors.newCachedThreadPool();
Review Comment:
Have you considered using an
[Thread.UncaughtExceptionHandler](https://docs.oracle.com/javase/7/docs/api/java/lang/Thread.UncaughtExceptionHandler.html)
instead?
##########
src/components/src/test/kotlin/org/apache/jmeter/threads/openmodel/OpenModelThreadGroupConfigElementTest.kt:
##########
@@ -0,0 +1,90 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to you under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.jmeter.threads.openmodel
+
+import org.apache.jmeter.control.TestTransactionController
+import org.apache.jmeter.engine.StandardJMeterEngine
+import org.apache.jmeter.junit.JMeterTestCase
+import org.apache.jmeter.modifiers.CounterConfig
+import org.apache.jmeter.sampler.DebugSampler
+import org.apache.jmeter.testelement.TestPlan
+import org.apache.jmeter.testelement.property.TestElementProperty
+import org.apache.jmeter.threads.AbstractThreadGroup
+import org.apache.jorphan.collections.ListedHashTree
+import org.apache.jorphan.test.JMeterSerialTest
+import org.junit.Assert
+import org.junit.Test
+import java.time.Duration
+
+class OpenModelThreadGroupConfigElementTest : JMeterTestCase(),
JMeterSerialTest {
Review Comment:
Really nice test class.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
