sandra-thieme commented on code in PR #5757:
URL: https://github.com/apache/jmeter/pull/5757#discussion_r1070928017
##########
build.gradle.kts:
##########
@@ -98,6 +98,8 @@ val rat by
tasks.getting(org.nosphere.apache.rat.RatTask::class) {
verbose.set(true)
// Note: patterns are in non-standard syntax for RAT, so we use
exclude(..) instead of excludeFile
exclude(rootDir.resolve(".ratignore").readLines())
+ exclude("src/dist-check/temp")
+ dependsOn(":src:dist:copyBinLibs", ":src:dist:copyLibs")
Review Comment:
This change is intended. It is necessary to support incremental builds for
the `rat` task:
```
Execution optimizations have been disabled for task ':rat' to ensure
correctness due to the following reasons:
- Gradle detected a problem with the following location:
'/Users/sandra/experiments/gradle-enterprise-gradle-build-validation/.data/01-validate-incremental-building/20230105T073724-63b67024/build_jmeter'.
Reason: Task ':rat' uses this output of task ':src:dist:copyBinLibs' without
declaring an explicit or implicit dependency. This can lead to incorrect
results being produced, depending on what order the tasks are executed. Please
refer to
https://docs.gradle.org/7.3/userguide/validation_problems.html#implicit_dependency
for more details about this problem.
- Gradle detected a problem with the following location:
'/Users/sandra/experiments/gradle-enterprise-gradle-build-validation/.data/01-validate-incremental-building/20230105T073724-63b67024/build_jmeter'.
Reason: Task ':rat' uses this output of task ':src:dist:copyLibs' without
declaring an explicit or implicit dependency. This can lead to incorrect
results being produced, depending on what order the tasks are executed. Please
refer to
https://docs.gradle.org/7.3/userguide/validation_problems.html#implicit_dependency
for more details about this problem.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
