FSchumacher opened a new pull request, #5796:
URL: https://github.com/apache/jmeter/pull/5796

   ## Description
   
   Warn only once, when `u` is found in format string of the `__time` function.
   
   ## Motivation
   
   There could be other reasons, why `u` is contained in the format string. So 
use the format with a known date and check the result, if `u` might have been 
used.
   
   The warning will be issued only once.
   
   This implementation has a few loopholes/problems:
    * `u` could still be used for something different and the year could be 
coming from a `YYYY` format string
    * we add a volatile variable, which adds overhead
   
   I start to believe that it is probably better to revert to the old logic and 
live with the IDE warnings.
   
   Part of #5694
   
   ## How Has This Been Tested?
   
   Used two different format strings in the GUI and watched the logs.
   
   ## Types of changes
   <!--- What types of changes does your code introduce? Delete as appropriate 
-->
   - Bug fix (non-breaking change which fixes an issue)
   
   ## Checklist:
   <!--- Go over all the following points, and put an `x` in all the boxes that 
apply. -->
   <!--- If you're unsure about any of these, don't hesitate to ask. We're here 
to help! -->
   - [x] My code follows the [code style][style-guide] of this project.
   - [ ] I have updated the documentation accordingly.
   
   [style-guide]: https://wiki.apache.org/jmeter/CodeStyleGuidelines
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to