weisJ commented on PR #5715: URL: https://github.com/apache/jmeter/pull/5715#issuecomment-1535307918
> Could you please clarify which classloader do you mean? I am referring to the `DynamicClassLoader` here https://github.com/apache/jmeter/blob/b0692252777dbf473b713fe40b38a1d3dfdc3b9b/src/launcher/src/main/java/org/apache/jmeter/NewDriver.java#L55 > I thought the button labels "yes/no/cancel" should be loaded from the system bundles. The dialog uses a regular JOptionPane.YES_NO_CANCEL_OPTION, so do not understand why custom classloaders break it. Usually they are and before strong encapsulation was fully enforced third party LaFs were able to load them aswell, but with newer Java versions that is no longer possible. Hence the resource bundle as the replicated and packaged separately. Sadly due to the implementation of `UIDefaults` these are always loaded using the system classloader: https://github.com/openjdk/jdk/blob/197d0cc6031cb470f1bd7678796593ff1bf440ca/src/java.desktop/share/classes/javax/swing/UIDefaults.java#L318 I have now opted for duplicating the resource cache, which fixes this issue. ---- > First you say Miglayout supports the visual paddings, then you say it does not. I'm puzzled. I'm sorry I have reworded my comment a few times and it came out rather scrabled. Let me clarify. Miglayout applies the adjustments for `visualPaddings` after it has already determined the location for the component (which of course takes these paddings into account). However a constraint of `fillx` will always result in the component to always have the right edge **before** the paddings are compensated for. This results in the child components bounding box extending outside of its parent, hence the clipped off focus ring. Newer versions of MigLayout seem to have the same problem. I have submitted a PR https://github.com/mikaelgrev/miglayout/pull/94 which should fix it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
