vlsi commented on code in PR #727:
URL: https://github.com/apache/jmeter/pull/727#discussion_r1190833187
##########
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/control/HeaderManager.java:
##########
@@ -57,9 +58,19 @@ public HeaderManager() {
setProperty(new CollectionProperty(HEADERS, new ArrayList<>()));
}
+ private void assertMutable() {
+ if (isRunningVersion()) {
+ throw new IllegalStateException(
+ "Cannot modify HeaderManager " + getName() + " while test
is running. " +
+ "If you need dynamic headers, prefer using ${...}
expressions in your headers."
Review Comment:
Function Helper Dialog generates functions. I'm not sure it can generate
variables.
---
> expression language
Well, the language is something that declares parsing and semantic rules.
For instance, neither function nor variable can specify if nested ${...} are
allowed. Neither function nor variable can specify the way to escape $ if the
user needs literal $ value without replacements.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
