vlsi commented on PR #5900: URL: https://github.com/apache/jmeter/pull/5900#issuecomment-1547448302
>So, why are there no tests for ClientJmeterEngine? I have no idea. It can be some tests are missing. It can be the tests are executed from certain batch tests only. It can be IntelliJ code coverage does not track tests spawned from batch tests because they execute JMeter as a custom subprocess, so they don't automatically inherit IntelliJ code coverage agent options. --- >but i simply don't have the time to create Tests for ClientJMeterEngine and PreCompiler from scratch. I understand what you say. However, at the same time, I would mention that the code without tests is hard to maintain. Imagine some time later I would start working on https://github.com/apache/jmeter/issues/5877 What would I do with the code you suggest in this PR? It would be hard to "just drop the code", however, it would be hard to understand if it still works as intended. That is one of the "maintenance overheads" we have. The bug https://github.com/apache/jmeter/issues/5896 does not affect me directly, and I have no time for looking into it either. So it would be great if you could reconsider and spend a little bit of time creating tests to cover your changes. An alternative option might be waiting for somebody else to do it. Thank you for understanding. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
