vlsi commented on code in PR #5805:
URL: https://github.com/apache/jmeter/pull/5805#discussion_r1198825273
##########
src/core/src/main/java/org/apache/jmeter/save/CSVSaveService.java:
##########
@@ -786,7 +785,13 @@ private void addDelim() {
// quotes:
public void append(String s) {
addDelim();
- sb.append(quoteDelimiters(s, specials));
+ sb.append(escapeControlChars(quoteDelimiters(s, specials)));
+ }
+
+ private static String escapeControlChars(String value) {
+ return value
+ .replace("\n", "\\n")
+ .replace("\r", "\\r");
Review Comment:
This looks strange as `\n` and `\r` are already a part of `specials`, so
they should already be replaced
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
