nagkumar commented on issue #5957: URL: https://github.com/apache/jmeter/issues/5957#issuecomment-1579010544
Another Observation is JUnitSampler is optionally measuring only test method time and not setup and teardown methods, that is a misleading info, as these two are part of test execution. Also another bug is there could be many setup and teardown methods both in JUnit 4 and JUnit 5.. [https://medium.com/javarevisited/execution-order-of-junit-annotations-cda673cda470](https://medium.com/javarevisited/execution-order-of-junit-annotations-cda673cda470)  However, JUnitSampler just handle only one method of setup and teardown.. Also JUnitSampler expects both default constructor and constructor with string name.. while real testcase fails to execute such 2 constructor test case.. not sure if any have use JUnitSampler at all.. Keeping it similar could be just take the JUnit 5 Suite Class and JUnit Test Class (optionally with test method or test methods) and execute them through JUnit 5 Lanucher.. That way even UI would be simple and easy to understand, once JUnit 5 is accepted, I am sure we can find the same JUnit5Sampler to accept both JUnit 4 and JUnit 3 too.. as JUnit 5 has such support engines. Pl. share your thoughts to further clarify the scope -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
