vlsi commented on code in PR #6353:
URL: https://github.com/apache/jmeter/pull/6353#discussion_r1773649423
##########
src/core/src/main/kotlin/org/apache/jmeter/threads/openmodel/OpenModelThreadGroup.kt:
##########
@@ -204,7 +204,7 @@ public class OpenModelThreadGroup :
val seed = randomSeed
val rnd = if (seed == 0L) Random() else Random(seed)
val gen = ThreadScheduleProcessGenerator(rnd, parsedSchedule)
- val testStartTime = JMeterContextService.getTestStartTime()
+ val testStartTime = System.currentTimeMillis()
Review Comment:
`JMeterContextService.getTestStartTime` is used in
`ConstantThroughputTimer`, `PreciseThroughputTimer`.
I expect the classes will have the same issue regarding long setup thread
groups.
At the same time, all of those might appear under setup thread groups as
well. WDYT of using something like "thread group start time"?
Of course, for `OMTG` it is a bit easier as `start` corresponds to the
thread group start, however, the timers should probably refer to the start time
of the corresponding thread groups.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
