vlsi commented on code in PR #6306:
URL: https://github.com/apache/jmeter/pull/6306#discussion_r1778253521


##########
src/protocol/http/src/main/java/org/apache/jmeter/protocol/http/proxy/DefaultSamplerCreator.java:
##########
@@ -268,7 +268,7 @@ protected void computeFromPostBody(HTTPSamplerBase sampler,
                         HTTPFileArg [] files = {new 
HTTPFileArg(out.getPath(),"",contentType)};
                         sampler.setHTTPFiles(files);
                     } catch (IOException e) {
-                        log.warn("Could not create binary file: {}", e);
+                        log.warn("Could not create binary file", e);

Review Comment:
   The last "exception" parameter should not be present in the string format 
message, so `("Could not create binary file", e);` is the right way to go to 
show the stacktrace



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@jmeter.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to